Use Smack 4.1.0-beta1#776
Open
Flowdalic wants to merge 4327 commits into
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd wanted to know how much effort it would be to update Smack in Essentials. Seems pretty easy, but this needs some more testing. Please do not merge until someone else has tested this too.
Especially since Smack 4 is more strict about security, an option to use TLS pinning or to accept all TLS certificates should be considered. But I want to get some feedback from the Essentials developers first before I put more work into it.